Skip to content

Add best practices for applies_to #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 14, 2025
Merged

Add best practices for applies_to #1614

merged 35 commits into from
Aug 14, 2025

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Jul 25, 2025

Closes https://github.com/elastic/docs-content-internal/issues/55

Restructures and adds to the docs on how to write cumulative documentation.

I started collecting examples from across Slack and GitHub where the Docs team has been discussing how we should approach cumulative documentation in different scenarios. This will add a best practices doc outlining what I've found. There are some situations where I've found conflicting or incomplete advice. In those cases, I'll try to get consensus. 🙃

Approach

Splits content on writing cumulative documentation into several pages with different goals and/or audiences based on conversations I've had over the last couple months with dev teams, other writers, and other docs contributors:

  • Intro to cumulative documentation:
    • Audience: Anyone who is curious about the cumulative documentation model whether or not they contribute to docs regularly (or at all).
    • Goals:
      • Introduce the concept of cumulative documentation.
      • Explain its impacts on both readers and contributors.
      • Point docs contributors to more detailed resources on how to write cumulative documentation.
  • Guidelines:
    • Audience: Anyone who contributes to docs.
    • Goals:
      • Provide general guidance that is appropriate for both experienced and new docs contributors.
      • Point docs contributors to specific examples as needed without distracting from general guidance.
  • Badge placement:
    • Audience: Technical writers and other frequent docs contributors.
    • Goals:
      • Provide guidance on badge placement in specific situations to promote consistency.
  • Example scenarios:
    • Audience: Technical writers and other frequent docs contributors.
    • Goals:
      • Provide realistic, detailed examples of common scenarios docs contributors will run into.
      • Help docs contributors choose the best solution.
  • Quick reference:
    • Audience: Anyone who contributes to docs.
    • Goals:
      • Make it easier for those who are already familiar with applies_to to find the list of valid values without having to dig through all the information in Syntax > Applies to.

I also moved the content in Versions and types closer to the docs on cumulative documentation.

For reviewers

Where there was conflicting guidance in GitHub/Slack or docs contributors used inconsistent strategies across the live docs, I tried to make a judgement call. If you you disagree or have another approach we should consider, feedback/input is very welcome! I tried to highlight some of the spiciest takes 🌶️ with a code comment: % FOR THE REVIEWER.

My focus in this PR is to capture the nuances of cumulative documentation and providing guidance on as many scenarios as possible. I haven't had a chance to reread the content for copy editing purposes. If anyone wants to do an editing pass they are welcome to edit and commit changes directly instead of adding MANY suggestions.

@colleenmcginnis colleenmcginnis self-assigned this Jul 25, 2025
@colleenmcginnis colleenmcginnis added documentation Improvements or additions to documentation DO NOT MERGE labels Jul 25, 2025
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some initial comments and suggestions. I still have a lot of content to go through. This is a great addition to the OG CD docs that Shaina created.

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more thoughts for ya.

@colleenmcginnis
Copy link
Contributor Author

colleenmcginnis commented Aug 8, 2025

@bmorelli25 @georgewallace these page are ready (enough) for review:

@colleenmcginnis colleenmcginnis changed the title [work in progress!!] Add best practices for applies_to Add best practices for applies_to Aug 11, 2025
@colleenmcginnis colleenmcginnis marked this pull request as ready for review August 11, 2025 23:43
@colleenmcginnis colleenmcginnis requested review from a team as code owners August 11, 2025 23:43
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I just have some qualms with the cumulative docs introduction, I understand that most of this content is pre-existing, so feel free to ignore.

Co-authored-by: Liam Thompson <[email protected]>
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pt1

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job everyone. Let's merge this so folks can start putting the guidance into practice.

We have a lot to figure out still, but we can have those conversations and update the docs as decisions are made.

@colleenmcginnis colleenmcginnis merged commit b767a42 into main Aug 14, 2025
19 checks passed
@colleenmcginnis colleenmcginnis deleted the applies_to-examples branch August 14, 2025 19:00
@colleenmcginnis
Copy link
Contributor Author

Follow-up tasks being tracked in https://github.com/elastic/docs-content-internal/issues/208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.