-
Notifications
You must be signed in to change notification settings - Fork 26
Add best practices for applies_to
#1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some initial comments and suggestions. I still have a lot of content to go through. This is a great addition to the OG CD docs that Shaina created.
Co-authored-by: Brandon Morelli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more thoughts for ya.
… into applies_to-examples
@bmorelli25 @georgewallace these page are ready (enough) for review:
|
348d2b0
to
3560d44
Compare
applies_to
applies_to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, I just have some qualms with the cumulative docs introduction, I understand that most of this content is pre-existing, so feel free to ignore.
Co-authored-by: Liam Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pt1
docs/contribute/cumulative-docs/_snippets/content-patterns-list.md
Outdated
Show resolved
Hide resolved
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
Co-authored-by: shainaraskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job everyone. Let's merge this so folks can start putting the guidance into practice.
We have a lot to figure out still, but we can have those conversations and update the docs as decisions are made.
Follow-up tasks being tracked in https://github.com/elastic/docs-content-internal/issues/208 |
Closes https://github.com/elastic/docs-content-internal/issues/55
Restructures and adds to the docs on how to write cumulative documentation.
I started collecting examples from across Slack and GitHub where the Docs team has been discussing how we should approach cumulative documentation in different scenarios. This will add a best practices doc outlining what I've found. There are some situations where I've found conflicting or incomplete advice. In those cases, I'll try to get consensus. 🙃
Approach
Splits content on writing cumulative documentation into several pages with different goals and/or audiences based on conversations I've had over the last couple months with dev teams, other writers, and other docs contributors:
applies_to
to find the list of valid values without having to dig through all the information in Syntax > Applies to.I also moved the content in Versions and types closer to the docs on cumulative documentation.
For reviewers
Where there was conflicting guidance in GitHub/Slack or docs contributors used inconsistent strategies across the live docs, I tried to make a judgement call. If you you disagree or have another approach we should consider, feedback/input is very welcome! I tried to highlight some of the spiciest takes 🌶️ with a code comment:
% FOR THE REVIEWER
.My focus in this PR is to capture the nuances of cumulative documentation and providing guidance on as many scenarios as possible. I haven't had a chance to reread the content for copy editing purposes. If anyone wants to do an editing pass they are welcome to edit and commit changes directly instead of adding MANY suggestions.